-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add max_current
sensor
#385
Conversation
Hi, me again 😁 I think the value you are using here for max current is still not quite providing what I would like. You are returning the The documentation says this value is "the actual max current value defined either by max_current_soft or a running claim". So it may not be the same as MAX CURRENT in OpenEVSE settings. I think you need to return |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage ? 83.91%
=======================================
Files ? 12
Lines ? 945
Branches ? 0
=======================================
Hits ? 793
Misses ? 152
Partials ? 0 ☔ View full report in Codecov by Sentry. |
They are the same value, I've verified this on my device. When I adjust the max current both values change. |
But if you were to issue a |
I did issue a claim, max_current didn't change only the "charge rate" changed. |
Interesting. The OpenEVSE documentation is certainly vague, and I believe in this case flat out wrong then. Empirical testing FTW. Thanks! |
I also verified adjusting the selector changes the "Charge Rate" as it's labeled in the UI without it adjusting the "Max Current" 🙂 |
fixes #384
Provides
max_current
sensor.Change old "max current" selector to
Charge Rate
to better reflect it's use.